[Xerte-dev] Re: Added unmark for completion

[Ron Mitchell]

Hi Tom

I pulled down the changes and had a quick look but will test further when I have more time. A few quick comments:

 

I think the default being marked is a good solution. Does that apply to all existing LO’s too - I suspect it does but thought I should check?

FA Icons seem fine. The unmark for completion looks a bit like a delete icon but I can’t think of anything better from the FA set right now.

Agree the progress bar should take account of pages unmarked for completion so if unmarked not calculated as part of the total/percentage. Or should that be optional?

Personally I’m not sure about having a grey background behind hidden page name and icons. I know we already had the grey background behind the page name but somehow having that span across the whole line makes it look like it’s selected. I wonder if the text color of the page name should just turn grey rather than have a background? But it’s a small point and others may think differently.

Will test further asap.

Ron

 

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Tom Reijnders
Sent: 19 June 2017 10:22
To: For Xerte technical developers <xerte-dev at lists.nottingham.ac.uk>
Subject: [Xerte-dev] Added unmark for completion

 

Guys and Girls,

I comitted the following:

Add unmark for completion optional parameter 

 - Replace mark for completion, so default behaviour is marked!
 - Use fontaweson icon to indicate in tree
 - replace hidden and deprecated icons with fontawesome icons
 - Refactor the way the icons are placed and removed and use css, i.e.
   icons are always places, but made visible/invisable with classes


So, instead of having a mark for completion, I created an unmark for completion, in order to have mark for completion as the default.
It would be good if the progressbar could also make use of this functionality (I think).

I also refactored the code that manipulates the icons and states of the tree node. So for example, the background colour of the whole node is changed, instead of only the text and I used font awesome for the icons instead of images. Please feel free to suggest alternatives.

I would appreciate some testing of the behaviour (hiding/unhiding pages, unmark/mark for completion, add optional parameter, remove optional parameter)

Regards,

Tom






 
 
 
This message and any attachment are intended solely for the addressee
and may contain confidential information. If you have received this
message in error, please send it back to me, and immediately delete it. 
 
Please do not use, copy or disclose the information contained in this
message or in any attachment.  Any views or opinions expressed by the
author of this email do not necessarily reflect the views of the
University of Nottingham.
 
This message has been checked for viruses but the contents of an
attachment may still contain software viruses which could damage your
computer system, you are advised to perform your own checks. Email
communications with the University of Nottingham may be monitored as
permitted by UK legislation.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20170619/7dce67e1/attachment.html>