[Xerte-dev] Re: Making the "Do you want to publish your changes?" popup optional?

[Julian Tenney]

I haven't had a chance to look at the pull request yet. Having an option for the user to toggle on / off a setting like 'always show this when closing the editor' would work. Publishing should always be a conscious action, for several good reasons, and if a user chooses not to see the dialog, then that's up to them.

-----Original Message-----
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Smith, Bradley
Sent: 10 May 2015 22:55
To: For Xerte technical developers
Subject: [Xerte-dev] Making the "Do you want to publish your changes?" popup optional?

At least when I am first developing an LO, it's much more likely that I don’t want to publish, even if I happen to be closing the editor for now. With this new popup it’s only a matter of time before I absent-mindedly press Enter to make it go away and end up publish something I didn’t mean to. What would people think about either including an option to not do this (maybe based on something settable in the LO/workspace’s properties?) or replacing the javascript confirm() that is currently used (looks like this comes from file_need_save() in template_management.js, based on output from versioncontrol/template_close.php?) with something less obtrusive, like a yes/no bar that appears above the normal Xerte New Folder, Publish, etc buttons. I can put in some time to work on this (at least the settings-based one, which sounds simpler), but I want to see what others think before just diving in.

—Brad