[Xerte-dev] Re: selecting embed code in the project details panel

[Ron Mitchell]

Tom and John have both replied via github - removed and committed.

 

Can you reproduce issue #361?
https://github.com/thexerteproject/xerteonlinetoolkits/issues/361 

 

I can't but may be misunderstanding the steps John describes.

 

From: xerte-dev-bounces at lists.nottingham.ac.uk
[mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Julian Tenney
Sent: 28 July 2015 13:52
To: For Xerte technical developers
Subject: [Xerte-dev] Re: selecting embed code in the project details panel

 

Can reproduce it here as well. I don't see why removing the return false
should cause an issue - but I didn't put it there to begin with,  so also
suspect that it does serve some purpose. If you remove it it still works
fine in the other browsers? I'd say go for it, I don't think it can affect
anything else,

 

From: xerte-dev-bounces at lists.nottingham.ac.uk
[mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Ron Mitchell
Sent: 28 July 2015 13:15
To: 'For Xerte technical developers'
Subject: [Xerte-dev] selecting embed code in the project details panel

 

Hi

I added this as an issue on github this morning
https://github.com/thexerteproject/xerteonlinetoolkits/issues/362 

In IE10 and 11 the embed code box in the project details pane doesn't allow
selection either by single click or by click and drag or by right click
select all. So the embed code can't be selected from that panel at the
moment. 

In Chrome I can click and drag to select the embed code and then copy it so
that works but right click select all doesn't.

In Firefox, initial single click, drag to select all and right click select
all - all these methods work.

 

With a bit of searching and John's pointer too it seems this is down to body
onselectstart="return false;" in index.php

 

Does that serve a useful/important purpose? Is there a way to reverse that
just for the embed code textarea or iframe?

 

As far as I can tell removing that from index.php doesn't prevent anything
else from working but it must have been there for a reason? Perhaps it dates
back to the older workspace prior to the tree view?

 

Cheers

Ron

 
 
 
This message and any attachment are intended solely for the addressee
and may contain confidential information. If you have received this
message in error, please send it back to me, and immediately delete it. 
 
Please do not use, copy or disclose the information contained in this
message or in any attachment.  Any views or opinions expressed by the
author of this email do not necessarily reflect the views of the
University of Nottingham.
 
This message has been checked for viruses but the contents of an
attachment may still contain software viruses which could damage your
computer system, you are advised to perform your own checks. Email
communications with the University of Nottingham may be monitored as
permitted by UK legislation.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20150728/a99fe554/attachment-0001.html>