[Xerte-dev] Re: New pull requests, and a style question

[Julian Tenney]

Hi Brad,

Many thanks. Somebody needs to review the pull requests. We also need you to sign a contributors agreement - as you know we are in the process of transitioning to the Apereo Foundation, and as part of the incubation process we are putting in place the agreements. We might need your employer to sign one as well, depending on your situation... can I put you in touch with Anna Gardner, who is helping with the legal stuff?

Personally I prefer...

if (somebadshit){
  exit();
}

// we didn't exit - rest of code here
doStuff();

...but I don't think anyone is going to start a holy war about it. You're in the right place for the github.


Julian

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Smith, Bradley
Sent: 03 November 2014 17:13
To: For Xerte technical developers
Subject: [Xerte-dev] New pull requests, and a style question

Hello all,

I just submitted my first couple of pull requests to Xerte, which fix a number of issues I had trying to go through the setup process with the devel code.

One of the pull requests is a fix for this issue:

  https://github.com/thexerteproject/xerteonlinetoolkits/issues/83

In the comments, starting from here<https://github.com/thexerteproject/xerteonlinetoolkits/issues/83#issuecomment-59792567>, there is some discussion about a stylistic question: if you have an if{} block that results in an exit(), do you need to put the stuff that comes after it in an else{}? Personally my answer to that is "no", and this is reflected in the fix I submitted<https://github.com/thexerteproject/xerteonlinetoolkits/pull/87>, but pgogy suggested I mention it here to see if others have opinions.

...also, just to be sure I'm in the right place, this github repo is where active development on the latest version of Xerte is happening, correct?

-Brad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20141104/fc7070d0/attachment.html>