[Xerte-dev] Re: Various pull requests on github (sqlite support, security fixes, export zip fixes).

[Tom Reijnders]

Ah. Thanks.

I am not sure either, buy I am in favour of using PDO.
Certainly if there is also a sqlite solution for people that don't care.
We can even add a 3rd file for mysqli....

Thanks for all this work. It was on my list, but simply didn't have the 
time.

Tom


David Goodwin schreef op 14-5-2014 10:02:
> Hi - Yes, database_library.php is the only place that has mysql_ calls.
>
> There should also be a database_library_sqlite.php.
>
> It's not particularly elegant, but the code should use one or the 
> other to show it switching between the two.
>
> I wasn't sure if it could be rewritten to use PDO or not (in that, I 
> wasn't sure if PDO would be an acceptable solution).
>
> David.
>
> Tom Reijnders wrote:
>>
>> David,
>>
>> After the merge my database_library.php still uses mysql_ calls. Is
>> that correct, or did something go wrong during the merge?
>> It's easy enough to update now, but I was just wondering.
>>
>> Tom
>>
>> David Goodwin schreef op 12-5-2014 17:54:
>>>
>>> Hi,
>>>
>>> See :
>>>
>>> https://github.com/thexerteproject/xerteonlinetoolkits/pull/65
>>>
>>> * changes XOT to break it's dependency on mysql_ (outside of 'setup')
>>> * removes the requirement to have mysql - it is defaulting to sqlite
>>> - this ought to make it easier for people to test.
>>> * removes any need to have a 'setup/' installer (to a large part).
>>> Chucking the files into a web server and browsing to the install
>>> should trigger it to create an empty database in the system temp dir.
>>>
>>>
>>> See :
>>>
>>> https://github.com/thexerteproject/xerteonlinetoolkits/pull/66
>>>
>>> * When I browse away from the front page, or try and reload it,
>>> Firefox get's stuck in a refresh loop.
>>>
>>>
>>> and :
>>>
>>> See :
>>>
>>> https://github.com/thexerteproject/xerteonlinetoolkits/pull/57
>>>
>>> * Improve the storing of extra_flags against a template.
>>> * Add new ZIP export module (use php's ZIP extension if possible,
>>> otherwise fall back to the PHP userspace library).
>>> * this should resolve memory limit issues with exporting zip files.
>>>
>>>
>>> thanks
>>> David.
>>>
>>
>
> This message and any attachment are intended solely for the addressee 
> and may contain confidential information. If you have received this 
> message in error, please send it back to me, and immediately delete 
> it.   Please do not use, copy or disclose the information contained in 
> this message or in any attachment.  Any views or opinions expressed by 
> the author of this email do not necessarily reflect the views of the 
> University of Nottingham.
>
> This message has been checked for viruses but the contents of an 
> attachment may still contain software viruses which could damage your 
> computer system, you are advised to perform your own checks. Email 
> communications with the University of Nottingham may be monitored as 
> permitted by UK legislation.
>
>
>
>
> _______________________________________________
> Xerte-dev mailing list
> Xerte-dev at lists.nottingham.ac.uk
> http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev

-- 
--

Tom Reijnders
TOR Informatica
Chopinlaan 27
5242HM Rosmalen
Tel: 073 5226191
Fax: 073 5226196

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20140514/f150845f/attachment.html>