[Xerte-dev] Re: Updates to model and xwd files by JK 16th July

[Julian Tenney]

No, that sounds much more robust, thanks,

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Kemp Johnathan
Sent: 18 July 2012 15:44
To: For Xerte technical developers
Subject: [Xerte-dev] Re: Updates to model and xwd files by JK 16th July

Unless there was a later version which I have not seen I think the fix was to change the line

img = myImg.templateData.rsp[0].sizes[0].size[3].source;

to

img = myImg.templateData.rsp[0].sizes[0].size[5].source;

This worked until the page tried to load images for which there were fewer than 6 size examples, when it then tried to access out of range of the size array.

The problem I found was that different images had varying numbers of sizes so even a setting of 3 for some images was too high whilst for other images it located a small image.

I have included a loop through the available image sizes to try to find one that will display as large as the page can handle.

If I've missed something here and fixed something that was already fixed, I am sorry.

If that is the case you will be able to use the svn to roll back the change.

Kind regards

Johnathan

On 18 July 2012 15:10, Julian Tenney <Julian.Tenney at nottingham.ac.uk<mailto:Julian.Tenney at nottingham.ac.uk>> wrote:
I'd already fixed that...

From: xerte-dev-bounces at lists.nottingham.ac.uk<mailto:xerte-dev-bounces at lists.nottingham.ac.uk> [mailto:xerte-dev-bounces at lists.nottingham.ac.uk<mailto:xerte-dev-bounces at lists.nottingham.ac.uk>] On Behalf Of Kemp Johnathan
Sent: 18 July 2012 14:04
To: Xerte Developers Discussion List
Subject: [Xerte-dev] Re: Updates to model and xwd files by JK 16th July

Fay,

With respect to your list of issues with pages.

I have now fixed the image size issue with the flickr page so that it accommodates pictures with varying numbers of sizes available. The code now either uses the first size that will need constraining so that the image fills as much of the space available, or it uses the largest image available.

Kind regards

Johnathan

On 16 July 2012 18:04, Kemp Johnathan <johnathan.kemp at ntlworld.com<mailto:johnathan.kemp at ntlworld.com>> wrote:
Hi Folks

I have just committed the rest of my changes for today.

I noticed that a lot of model files now have language="en_GB" back in them.

I will take that out again either tonight or tomorrow.

Attached is list of actions done today so you can update your main list.

Kind regards

Johnathan




This message and any attachment are intended solely for the addressee and may contain confidential information. If you have received this message in error, please send it back to me, and immediately delete it. Please do not use, copy or disclose the information contained in this message or in any attachment. Any views or opinions expressed by the author of this email do not necessarily reflect the views of the University of Nottingham.

This message has been checked for viruses but the contents of an attachment may still contain software viruses which could damage your computer system: you are advised to perform your own checks. Email communications with the University of Nottingham may be monitored as permitted by UK legislation.

_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk<mailto:Xerte-dev at lists.nottingham.ac.uk>
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev

This message and any attachment are intended solely for the addressee and may contain confidential information. If you have received this message in error, please send it back to me, and immediately delete it.   Please do not use, copy or disclose the information contained in this message or in any attachment.  Any views or opinions expressed by the author of this email do not necessarily reflect the views of the University of Nottingham.

This message has been checked for viruses but the contents of an attachment
may still contain software viruses which could damage your computer system:
you are advised to perform your own checks. Email communications with the
University of Nottingham may be monitored as permitted by UK legislation.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20120718/473fd347/attachment-0001.html>