[Xerte-dev] Re: 1.9 zip

Wed Dec 12 09:24:09 GMT 2012

Isn't that what I said?

I guess what you mean is that there's a difference between the publish button in the editor and the publish button in the workspace e.g. if you make a change and don't preview or publish in the editor then any changes are lost because if you don't preview you don't see a prompt to publish upon close. If you publish in the editor then changes are already published so there's no need for the prompt. If you preview any changes are saved to preview.xml and then either publish in the editor, ok to publish upon close, or publish later will publish those changes.

Your recent changes seem to have fixed the IE 9 issue I was getting. Will update the techdis install and test there shortly.

Cheers

Ron

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 12 December 2012 09:07
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

That's true, because publish in the xerte window does a double save (updates preview and data) - but unless  you preview or publish your changes are lost

On 12 Dec 2012, at 09:05, "Ron Mitchell" <ronm at mitchellmedia.co.uk> wrote:

" That button won't change that, all the publish does is copy preview over data - if preview wasn't updated by previewing then the button makes no difference at all."

I was surprised by that comment Pat because I'll often make changes and click publish without first previewing especially if it was only a minor change and therefore saves time not previewing. I'm not aware that I've ever lost changes that way and just checked...

Edit an LO and add a new page

Click publish in the editor but not preview

View the public url the new page is included

View via preview the new page is included

As far as I can see clicking publish therefore adds any changes to preview.xml as well as data.xml?

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 12 December 2012 01:22
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

"Closing without first previewing or publishing always has the potential to lose changes especially now that the close + OK to publish isn't working!"

That button won't change that, all the publish does is copy preview over data - if preview wasn't updated by previewing then the button makes no difference at all.

On Tue, Dec 11, 2012 at 4:10 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:

John

Publish saves changes to data.xml

Preview saves changes to preview.xml

Closing without first previewing or publishing always has the potential to lose changes especially now that the close + OK to publish isn't working!

So in terms of what has changed it's just that closing and clicking ok to publish isn't working. It's always been the case that unless you preview changes are not saved unless you manually publish or when clicking ok works.

HTH

Ron

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Smith, John
Sent: 11 December 2012 15:44

To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

Yeah what I’m seeing is:

I make a LO, add some stuff and then click Publish.

Then I make it Public, edit it again click Publish, close and Preview  = changes are there…

Then I Edit it again, make changes but just click the close button. No popup and when I click Preview the changes are lost…

This is in both Chrome and IE and from SVN trunk, latest revision. Are you guys working from a zip copy of trunk already?

Will checkout a fresh trunk and see what happens…

Regards,

John Smith

Learning Technologist

School of Health & Life Sciences

Glasgow Caledonian University

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: Tuesday, December 11, 2012 1:42 PM
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

If you don't preview then it isn't saved to preview.xml

The pop up should happen if data and preview.xml are different

On 11 Dec 2012, at 11:36, "Smith, John" <J.J.Smith at gcu.ac.uk> wrote:

Hi all,

Correct me if I’m wrong but if you made a change in the editor and then closed the window without Publishing you used to get a popup? I’m not getting that at all now at latest revision. Closing the window doesn’t give me any popup and the changes are lost now. Anyone else seeing this?

Regards,

John Smith

Learning Technologist

School of Health & Life Sciences

Glasgow Caledonian University

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: Tuesday, December 11, 2012 9:30 AM
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

Look at the top, there is a conditional which means temp array is sometimes created and sometimes not

So some cases will need it and some won't

On 11 Dec 2012, at 09:10, "Ron Mitchell" <ronm at mitchellmedia.co.uk> wrote:

Tried that but no change - project still not published upon clicking ok. Publishing manually works fine.

But still don't get why the files would be different? Your commit: http://code.google.com/p/xerteonlinetoolkits/source/browse/trunk/website_code/php/versioncontrol/update_file.php?spec=svn589 <http://code.google.com/p/xerteonlinetoolkits/source/browse/trunk/website_code/php/versioncontrol/update_file.php?spec=svn589&r=589> &r=589

has the four temp_array[0] and you're saying that file is working for you? Or did something go wrong with the commit?

Going to be offline for at least a few hours now so perhaps someone else can have a look.

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 10 December 2012 22:15
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

No idea - all four temp arrays need to be replaced 

As long as it is temp_array[0]

On 10 Dec 2012, at 20:20, "Ron Mitchell" <ronm at mitchellmedia.co.uk> wrote:

There seems to be two occurrences of temp_array[0] 

http://code.google.com/p/xerteonlinetoolkits/source/browse/trunk/website_code/php/versioncontrol/update_file.php?spec=svn589 <http://code.google.com/p/xerteonlinetoolkits/source/browse/trunk/website_code/php/versioncontrol/update_file.php?spec=svn589&r=589> &r=589

Do both need changing or just one?

How come this works for you if same version?

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 10 December 2012 18:28
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

Ok one of the queries has a ref to temp_array[0] in still

Replace with $template_id

On 10 Dec 2012, at 18:28, "Ron Mitchell" <ronm at mitchellmedia.co.uk> wrote:

do these help?

$query_for_play_content_strip

select originaltemplatesdetails.template_name, logindetails.username, originaltemplatesdetails.template_framework, templaterights.user_id, templaterights.folder, templaterights.template_id, templatedetails.access_to_whom from originaltemplatesdetails, templaterights, templatedetails, logindetails where templatedetails.template_type_id = originaltemplatesdetails.template_type_id and templatedetails.creator_id = logindetails.login_id and templaterights.template_id = templatedetails.template_id and templaterights.template_id="TEMPLATE_ID_TO_REPLACE" and role="creator"

$query_for_play_content

select originaltemplatesdetails.template_name, logindetails.username, originaltemplatesdetails.template_framework, templaterights.user_id, templaterights.folder, templaterights.template_id, templatedetails.access_to_whom from originaltemplatesdetails, templaterights, templatedetails, logindetails where templatedetails.template_type_id = originaltemplatesdetails.template_type_id and templatedetails.creator_id = logindetails.login_id and templaterights.template_id = templatedetails.template_id and templaterights.template_id="C:

mpphtdocs
rtetoolkits/USER" and role="creator"

$query_for_play_content_response

Resource id #20

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 10 December 2012 17:58
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

website_code/php/versioncontrol/update_file.php

there will be a variable called query or something query

On Mon, Dec 10, 2012 at 5:14 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:

Sorry what query? In what file?

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 10 December 2012 16:03

To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

Ok, so for you, the query doesn't work.

echo out the query and see what it is

On Mon, Dec 10, 2012 at 3:01 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:

I tested with a brand new svn update and export and a clean install using the xampp option so not sure why we're seeing different things. I truned on debugging and upon clicking ok to publish changes got the attached. Does that help?

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 10 December 2012 14:27

To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

Pah, 

It's been two years, but maybe that's my instinctive name for all things XOT

Well it works here on my XAMPP, but start putting echos in the code to see where it gets too. Easiest way to debug (it's all I'd do, but mine err, works).

Pat

On Mon, Dec 10, 2012 at 2:25 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:

Hi Pat

are you sure about the db name?

as far as I can see when using the quick xampp install option the db created is called toolkits_data as defines in \setup\xampp_database.txt

Testing the publishing options with a clean xampp install...

I get the prompt whether to publish with Chrome, Safari and FF but not IE. Possibly because I still get the window_reference error when using IE. Perhaps specific to my local IE?

But as Julian reported even when clicking ok to publish the changes aren't published until manually publishing.

HTH

Ron

From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 10 December 2012 14:12

To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

xertetoolkits

mine is a fresh xampp and it works

it's both files in versioncontrol and the response is alerted out so you can add echo "HELLO" to your heart's content to debug it

On Mon, Dec 10, 2012 at 1:06 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:

testing locally with guest access and no integration_config_path set...

Create project
Add a page
Preview (so the file is save)

Quit the wizard - I don't get prompted to publish at all even with the latest change Pat comitted
If I publish manually all is fine.

I'll test a clean install via xampp... If using the quick xampp install option what's the name of the db that gets created is it toolkits?

-----Original Message-----
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Julian Tenney
Sent: 10 December 2012 11:15
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

It still doesn't work:

Create project
Add a page
Preview (so the file is save)
Quit the wizard - prompted to publish - say yes Go to properties, make access public Hit the URL. Nothing until I publish from a button somewhere (workspace or wizard).

I think I'm going to put it out anyway, unless anyone can fix it today. I'm not so concerned about the html5 side of this not working, but previously working functionality doesn't work anymore. Maybe this isn't such a dealbreaker, perhaps we should disable the prompt and force a manual publish?

-----Original Message-----
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 07 December 2012 22:37
To: For Xerte technical developers
Subject: [Xerte-dev] Re: 1.9 zip

Not sure why it would break but adding database connect in seemed to fix it

On 7 Dec 2012, at 22:21, Julian Tenney <Julian.Tenney at nottingham.ac.uk> wrote:

> thanks mate, I'll test on Monday,
> ________________________________________
> From: xerte-dev-bounces at lists.nottingham.ac.uk
> [xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
> [patrick.lockley at googlemail.com]
> Sent: 07 December 2012 19:22
> To: For Xerte technical developers
> Subject: [Xerte-dev] Re: 1.9 zip
>
> fixed in moodle (both files in version control folder)
>
> Please test
>
>
> On Fri, Dec 7, 2012 at 12:07 PM, Julian Tenney <Julian.Tenney at nottingham.ac.uk<mailto:Julian.Tenney at nottingham.ac.uk>> wrote:
> It works from the publish buttons. Just not on the on close trapper
>
> From:
> xerte-dev-bounces at lists.nottingham.ac.uk<mailto:xerte-dev-bounces at list
> s.nottingham.ac.uk>
> [mailto:xerte-dev <mailto:xerte-dev-bounces at lists.nottingham.ac.uk> 

_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20121212/a9436b2d/attachment-0001.html>