[Xerte-dev] Re: moodle fix
Dave Burnett
d_b_burnett at hotmail.com
Wed Dec 5 12:47:10 GMT 2012
The pathing on Moodle 2.0 is a wild and crazy thing.Maybe 1.9 was a bit of a test bed for some of what became 2.0?Wild guessing.
Date: Wed, 5 Dec 2012 12:32:09 +0000
From: patrick.lockley at googlemail.com
To: xerte-dev at lists.nottingham.ac.uk
Subject: [Xerte-dev] Re: moodle fix
it's not really about introducing errors or changes, but why moodle 1.9 requires the code to be different? That seems a bit worrying.
On Wed, Dec 5, 2012 at 12:27 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:
I've been testing without a moodle integration path as well as with.
This particular window_reference error happens with and without a moodle integration path.
I'm testing via xampp but you can see it on the techdis install although that obviously is using moodle authentication.
I haven't found any other errors when testing without integration path so I'm not sure your changed files have introduced any problems unless this js error is a result of those changes.
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 05 December 2012 12:14
To: For Xerte technical developers
Subject: [Xerte-dev] Re: moodle fix
Yeah, my bad - not sure why that would happen. Nothing I've changed javascript side.
I wouldn't commit those changes as they just don't make sense to me. I don't get why moodle inclusion would cause those problems and I am not sure what they do outside of moodle.
On Wed, Dec 5, 2012 at 12:13 PM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:
I thought that window_reference is undefined is a js error?
BTW
Are you going to commit those changed php files or do you want me to on your behalf?
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 05 December 2012 12:02
To: For Xerte technical developers
Subject: [Xerte-dev] Re: moodle fix
Not sure then, I assumed it was that (as this was more of a patch than a fix)
Do you get a JS error?
On Wed, Dec 5, 2012 at 11:52 AM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:
Just print_r($_SESSION) or could there be a similar print_r(something) causing the same problem?
Have searched for print_r($_SESSION) in the install I'm using for testing and not found.
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 05 December 2012 11:42
To: For Xerte technical developers
Subject: [Xerte-dev] Re: moodle fix
I think it's because of the print_r($_SESSION) somewhere - remove that and it'll be fine
On Wed, Dec 5, 2012 at 11:36 AM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:
Hi Patthanks for the update.
I've been testing on both the techdis server and locally via xampp. Obviously I won't have tested every single permutation yet but from tests so far all seems fine apart from this issue of not being able to create a new project after creating one already until refresh. However this happens without a moodle integration path added too.
Here's the steps to reproduce with current svn code plus your changed files.
Click create to create a new project based on Xerte Online Toolkits template
Close the editor and try to create another project - nothing happens upon clicking create
Refresh the browser and click create works but the cycle repeats e.g. can't create a second project
Using debugger in IE9 I get the following error when closing the editor window:
SCRIPT5009: 'window_reference' is undefined
edit.php?template_id=17, line 32 character 1
Not really sure where to look for the cause/solution to this one but is there perhaps an include/require missing somewhere?
Cheers
Ron
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 05 December 2012 09:38
To: For Xerte technical developersSubject: [Xerte-dev] Re: moodle fix
the problem in new template was that for some reason moodle is leaving or creating another database link so when toolkits sends the request to the database it fails as the code is now pointing at the wrong database.
Added in another database_connect call to fix this
the problem in new folder creation was two require_once("config.php") being used. Removed one and it works.
Why these would only affect moodle 1.9? No idea.
On Wed, Dec 5, 2012 at 7:49 AM, Ron Mitchell <ronm at mitchellmedia.co.uk> wrote:
Hi Patthanks - from tests so far those files have certainly improved things!
What did you find/change? What was the main cause of the problem?
I've tested creating new projects and folders, moving and deleting projects all of which were a problem previously so looking hopeful.
One problem/difference at the moment which I don't think was there before is that with a moodle 1.9 integration path I can now create a new project without the workspace refreshing and it appears etc but if I then try to create a second project clicking create to create another Xerte Online Toolkit project doesn't do anything. I have to refresh the browser before I can create another project. Clicking to create an RSS project does work without refresh and with moodle 2 configured I can create a second and third template etc without problem.
I've only tested this locally so far will test on the techdis server next...
CheersRon
From: xerte-dev-bounces at lists.nottingham.ac.uk [mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat Lockley
Sent: 05 December 2012 00:29
To: For Xerte technical developers
Subject: [Xerte-dev] moodle fix try swapping these files
_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
_______________________________________________
Xerte-dev mailing list
Xerte-dev at lists.nottingham.ac.uk
http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20121205/e685d00a/attachment-0001.html>
More information about the Xerte-dev
mailing list