<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
p.commit-title, li.commit-title, div.commit-title
{mso-style-name:commit-title;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-GB" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US">I’m not all that familiar with the functionality, but to me the phrase ‘unmark for completion’ is difficult to understand. Would a user understand what is meant by it? Should it be
‘Do not track’? Like Ron I think having it as default is the right way to go.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US">I’ll have a look at the visuals at some point.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext"> xerte-dev-bounces@lists.nottingham.ac.uk [mailto:xerte-dev-bounces@lists.nottingham.ac.uk]
<b>On Behalf Of </b>Ron Mitchell<br>
<b>Sent:</b> 19 June 2017 11:42<br>
<b>To:</b> 'For Xerte technical developers' <xerte-dev@lists.nottingham.ac.uk><br>
<b>Subject:</b> [Xerte-dev] Re: Added unmark for completion<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Hi Tom<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">I pulled down the changes and had a quick look but will test further when I have more time. A few quick comments:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">I think the default being marked is a good solution. Does that apply to all existing LO’s too - I suspect it does but thought I should check?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">FA Icons seem fine. The unmark for completion looks a bit like a delete icon but I can’t think of anything better from the FA set right now.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Agree the progress bar should take account of pages unmarked for completion so if unmarked not calculated as part of the total/percentage. Or should that be optional?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Personally I’m not sure about having a grey background behind hidden page name and icons. I know we already had the grey background behind the page name but somehow having that span
across the whole line makes it look like it’s selected. I wonder if the text color of the page name should just turn grey rather than have a background? But it’s a small point and others may think differently.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Will test further asap.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Ron<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext">
<a href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk">xerte-dev-bounces@lists.nottingham.ac.uk</a> [<a href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk">mailto:xerte-dev-bounces@lists.nottingham.ac.uk</a>]
<b>On Behalf Of </b>Tom Reijnders<br>
<b>Sent:</b> 19 June 2017 10:22<br>
<b>To:</b> For Xerte technical developers <<a href="mailto:xerte-dev@lists.nottingham.ac.uk">xerte-dev@lists.nottingham.ac.uk</a>><br>
<b>Subject:</b> [Xerte-dev] Added unmark for completion<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Guys and Girls,<br>
<br>
I comitted the following:<o:p></o:p></p>
<p class="commit-title">Add unmark for completion optional parameter <o:p></o:p></p>
<div>
<pre> - Replace mark for completion, so default behaviour is marked!<o:p></o:p></pre>
<pre> - Use fontaweson icon to indicate in tree<o:p></o:p></pre>
<pre> - replace hidden and deprecated icons with fontawesome icons<o:p></o:p></pre>
<pre> - Refactor the way the icons are placed and removed and use css, i.e.<o:p></o:p></pre>
<pre> icons are always places, but made visible/invisable with classes<o:p></o:p></pre>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
So, instead of having a mark for completion, I created an unmark for completion, in order to have mark for completion as the default.<br>
It would be good if the progressbar could also make use of this functionality (I think).<br>
<br>
I also refactored the code that manipulates the icons and states of the tree node. So for example, the background colour of the whole node is changed, instead of only the text and I used font awesome for the icons instead of images. Please feel free to suggest
alternatives.<br>
<br>
I would appreciate some testing of the behaviour (hiding/unhiding pages, unmark/mark for completion, add optional parameter, remove optional parameter)<br>
<br>
Regards,<br>
<br>
Tom<br>
<br>
<br>
<br>
<o:p></o:p></p>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>This message and any attachment are intended solely for the addressee<o:p></o:p></pre>
<pre>and may contain confidential information. If you have received this<o:p></o:p></pre>
<pre>message in error, please send it back to me, and immediately delete it. <o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Please do not use, copy or disclose the information contained in this<o:p></o:p></pre>
<pre>message or in any attachment. Any views or opinions expressed by the<o:p></o:p></pre>
<pre>author of this email do not necessarily reflect the views of the<o:p></o:p></pre>
<pre>University of Nottingham.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>This message has been checked for viruses but the contents of an<o:p></o:p></pre>
<pre>attachment may still contain software viruses which could damage your<o:p></o:p></pre>
<pre>computer system, you are advised to perform your own checks. Email<o:p></o:p></pre>
<pre>communications with the University of Nottingham may be monitored as<o:p></o:p></pre>
<pre>permitted by UK legislation.<o:p></o:p></pre>
</div>
</body>
</html>