<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I can do it for you, if you prefer.<br>
<br>
<div class="moz-cite-prefix">Ron Mitchell schreef op 13-2-2015 om
14:04:<br>
</div>
<blockquote cite="mid:00bb01d0478d$a6377ec0$f2a67c40$@co.uk"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Thanks Tom<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">always a bit
nervous about all that so as it's just a simple change made
the change in Master online logged in to github. Will that
suffice? It now says: This branch is 1 commit ahead, 387
commits behind develop.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Cheers<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Ron<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext"
lang="EN-US">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext"
lang="EN-US"> <a class="moz-txt-link-abbreviated" href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk">xerte-dev-bounces@lists.nottingham.ac.uk</a>
[<a class="moz-txt-link-freetext" href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk">mailto:xerte-dev-bounces@lists.nottingham.ac.uk</a>] <b>On
Behalf Of </b>Tom Reijnders<br>
<b>Sent:</b> 13 February 2015 11:25<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:xerte-dev@lists.nottingham.ac.uk">xerte-dev@lists.nottingham.ac.uk</a><br>
<b>Subject:</b> [Xerte-dev] Re: 2.1 stable,
onbeforeunload and Déjà vu?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">You need to
commit this in master! master is the source for the stable 2.1
release.<o:p></o:p></p>
<div>
<p class="MsoNormal">Julian Tenney schreef op 13-2-2015 om
11:45:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">></span>1.
How best to remove the rougue onbeforeunload=<a
moz-do-not-send="true" href="javascript:logout()">"javascript:logout()"</a>
from 2.1? I could commit the change direct to 2.1 <o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">I think
that’s the best way if it is still there.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">I don’t know
about the ldap issues I’m afraid.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""
lang="EN-US">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""
lang="EN-US"> <a moz-do-not-send="true"
href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk">xerte-dev-bounces@lists.nottingham.ac.uk</a>
[<a moz-do-not-send="true"
href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk">mailto:xerte-dev-bounces@lists.nottingham.ac.uk</a>]
<b>On Behalf Of </b>Ron Mitchell<br>
<b>Sent:</b> 13 February 2015 10:43<br>
<b>To:</b> 'For Xerte technical developers'<br>
<b>Subject:</b> [Xerte-dev] 2.1 stable, onbeforeunload
and Déjà vu?</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi all<o:p></o:p></p>
<p class="MsoNormal">I know we've discussed this sort of thing
before but doesn't seem easy to locate and track back
through specific steps but anyway case in point…<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">You may have noticed I responded to the
question and thread on the community site re moodle
integration and helped Jayne get things working including I
think the last issue about logout not working. She hasn't
replied and confirmed yet but it seems very likely that the
problem with logout is the unecessary onbeforeunload=<a
moz-do-not-send="true" href="javascript:logout()">"javascript:logout()"</a>
in index.php which I'm pretty sure we've worked through and
discussed here before as well as Julian replying to a
previous mention of this on the community forums.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">I don't personally find it easy to
navigate the commits to spot changes in each branch etc and
so not sure whether the rogue code has ever been removed
from 2.1 or removed and somehow crept back. Also I seem to
recall that Julian orginally added that code to try to
resolve a firefox issue but not sure what the final result
of that was except that leaving it in causes more problems
than it fixes. I did an install of 2.1 earlier this week and
with hindsight noticed the issue then too but because of an
issue with the latest 2.1 and ldap (another story see below)
reverted to an earlier 2.1 revision which must have had that
code removed. So a few questions:<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">1. How best to remove the rougue
onbeforeunload=<a moz-do-not-send="true"
href="javascript:logout()">"javascript:logout()"</a> from
2.1? I could commit the change direct to 2.1 but not sure
that's the best way e.g. it's already removed from develop
but obviously develop isn't ready for production use.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">2. Are there other differences like this
e.g. later changes that aren't related to the new editor but
only in later branches and not in 2.1?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">3. I did an install of the latest 2.1
revision earlier this week and had problems when it came to
ldap. Login was working but project folders weren't being
created with the username included so breaking. I ended up
replace the install with an older revision which worked
immediately. There wasn't time to unpick the differences but
just wondering if anyone recognises that issue with LDAP and
which commit is relevant?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Cheers<o:p></o:p></p>
<p class="MsoNormal">Ron<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">BTW apologies if two copies of this
message reach the list - the first attempt bounced :-(<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>This message and any attachment are intended solely for the addressee<o:p></o:p></pre>
<pre>and may contain confidential information. If you have received this<o:p></o:p></pre>
<pre>message in error, please send it back to me, and immediately delete it. <o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Please do not use, copy or disclose the information contained in this<o:p></o:p></pre>
<pre>message or in any attachment. Any views or opinions expressed by the<o:p></o:p></pre>
<pre>author of this email do not necessarily reflect the views of the<o:p></o:p></pre>
<pre>University of Nottingham.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>This message has been checked for viruses but the contents of an<o:p></o:p></pre>
<pre>attachment may still contain software viruses which could damage your<o:p></o:p></pre>
<pre>computer system, you are advised to perform your own checks. Email<o:p></o:p></pre>
<pre>communications with the University of Nottingham may be monitored as<o:p></o:p></pre>
<pre>permitted by UK legislation.<o:p></o:p></pre>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><br>
<br>
<br>
<o:p></o:p></span></p>
<pre>_______________________________________________<o:p></o:p></pre>
<pre>Xerte-dev mailing list<o:p></o:p></pre>
<pre><a moz-do-not-send="true" href="mailto:Xerte-dev@lists.nottingham.ac.uk">Xerte-dev@lists.nottingham.ac.uk</a><o:p></o:p></pre>
<pre><a moz-do-not-send="true" href="http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev">http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev</a><o:p></o:p></pre>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><br>
<br>
<o:p></o:p></span></p>
<pre>-- <o:p></o:p></pre>
<pre>--<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Tom Reijnders<o:p></o:p></pre>
<pre>TOR Informatica<o:p></o:p></pre>
<pre>Chopinlaan 27<o:p></o:p></pre>
<pre>5242HM Rosmalen<o:p></o:p></pre>
<pre>Tel: 073 5226191<o:p></o:p></pre>
<pre>Fax: 073 5226196<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>This message and any attachment are intended solely for the addressee<o:p></o:p></pre>
<pre>and may contain confidential information. If you have received this<o:p></o:p></pre>
<pre>message in error, please send it back to me, and immediately delete it. <o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Please do not use, copy or disclose the information contained in this<o:p></o:p></pre>
<pre>message or in any attachment. Any views or opinions expressed by the<o:p></o:p></pre>
<pre>author of this email do not necessarily reflect the views of the<o:p></o:p></pre>
<pre>University of Nottingham.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>This message has been checked for viruses but the contents of an<o:p></o:p></pre>
<pre>attachment may still contain software viruses which could damage your<o:p></o:p></pre>
<pre>computer system, you are advised to perform your own checks. Email<o:p></o:p></pre>
<pre>communications with the University of Nottingham may be monitored as<o:p></o:p></pre>
<pre>permitted by UK legislation.<o:p></o:p></pre>
</div>
<pre>
This message and any attachment are intended solely for the addressee
and may contain confidential information. If you have received this
message in error, please send it back to me, and immediately delete it.
Please do not use, copy or disclose the information contained in this
message or in any attachment. Any views or opinions expressed by the
author of this email do not necessarily reflect the views of the
University of Nottingham.
This message has been checked for viruses but the contents of an
attachment may still contain software viruses which could damage your
computer system, you are advised to perform your own checks. Email
communications with the University of Nottingham may be monitored as
permitted by UK legislation.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Xerte-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xerte-dev@lists.nottingham.ac.uk">Xerte-dev@lists.nottingham.ac.uk</a>
<a class="moz-txt-link-freetext" href="http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev">http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
--
Tom Reijnders
TOR Informatica
Chopinlaan 27
5242HM Rosmalen
Tel: 073 5226191
Fax: 073 5226196
</pre>
</body>
</html>