<div dir="ltr"><div style="font-family:arial,sans-serif;font-size:13px">Well I agree with your disagreement :)</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
I think (personally) that revisiting each page means we might as well do more than just fix alter the db calls. I could have done this when I went through and internationalised the code, but I always assumed a new Nottingham PHP person would want to do their own thing with the code. I stick around here mostly as I like to help people but I always feel sad when an LDAP query occurs because I've no idea how that code works now. I worry a little that refactoring as a process will mean support / knowledge is with a set of people and there is no oracle who knows how everything works.</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">I think we could refactor just this, but it feels a bit of a shortcut? Maybe? </div><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px">I think we have to use an abstraction layer and happy to help write it.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 15, 2013 at 6:04 PM, Tom Reijnders <span dir="ltr"><<a href="mailto:reijnders@tor.nl" target="_blank">reijnders@tor.nl</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    I understand where you are coming from, and I understand your
    reasoning. But I respectfully disagree.<br>
    <br>
    This is just a typical re-factoring which we will be obliged to do
    from time to time. No new functionality involved, perhaps new
    opportunities.<br>
    <br>
    The question is more MySQLi vs. PDO.  Or a more generic approach
    Like David Goodwin used for authentication. We don't do anything
    fancy with the database.<br>
    <br>
    Tom<br>
    <br>
    <div>Pat @ Pgogy schreef op 15-10-2013
      18:56:<br>
    </div><div><div class="h5">
    <blockquote type="cite">
      <div dir="ltr">this is sort of why I think we needed a bigger set
        of goals for stuff
        <div><br>
        </div>
        <div>This has been coming for ages, but everyone at the moment
          is sort of solving their own problems (so to speak), and so
          this wasn't ever going to become a big deal, but is eventually
          going to stop everything.</div>
        <div><br>
        </div>
        <div>Most of the XOT code is heading to being almost 5 years old
          now, stuff like was always going to happen without a sort of
          core development thread going on</div>
      </div>
      <div class="gmail_extra"><br>
        <br>
        <div class="gmail_quote">
          On Tue, Oct 15, 2013 at 12:52 PM, Ron Mitchell <span dir="ltr"><<a href="mailto:ronm@mitchellmedia.co.uk" target="_blank">ronm@mitchellmedia.co.uk</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div link="blue" vlink="purple" lang="EN-GB">
              <div>
                <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks
                    Tom</span></p>
                <p class="MsoNormal">
                  <span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I'll
                    pass that on.</span></p>
                <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I
                    guess it could become a recurring problem at some
                    point.</span></p>
                <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Cheers</span></p>
                <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ron</span></p>
                <p class="MsoNormal"><a name="141bd132e6c6cc55_141bbf5e6d08cf94__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></a></p>
                <div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm">
                  <p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" lang="EN-US"> <a href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk" target="_blank">xerte-dev-bounces@lists.nottingham.ac.uk</a>
                      [mailto:<a href="mailto:xerte-dev-bounces@lists.nottingham.ac.uk" target="_blank">xerte-dev-bounces@lists.nottingham.ac.uk</a>]
                      <b>On Behalf Of </b>Tom Reijnders<br>
                      <b>Sent:</b> 15 October 2013 12:31<br>
                      <b>To:</b> For Xerte technical developers<br>
                      <b>Subject:</b> [Xerte-dev] Re: PHP compatibility</span></p>
                </div>
                <div>
                  <div>
                    <p class="MsoNormal"> </p>
                    <p>Ron,<br>
                      <br>
                      I created an issue for this already. The situtaion
                      is as follows:<br>
                      <br>
                      - Xerte uses the php mysql module, which is
                      deprecated from php 5.5<br>
                      - There is (already a long time) a new MySQLi
                      (mysql improved) module which we don't use<br>
                      - There is PDO.<br>
                      <br>
                      No idea how we are going to move forward (MySQLi
                      of PDO) in Xerte, but your collegue needs to make
                      sure to have mysql support in php for the time
                      being.<br>
                      <br>
                      Tom<br>
                      <br>
                      <br>
                      On Tue, 15 Oct 2013 11:03:24 +0100 "Ron Mitchell"
                      <<a href="mailto:ronm@mitchellmedia.co.uk" target="_blank">ronm@mitchellmedia.co.uk</a>>
                      wrote</p>
                    <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 6.0pt">
                      <div>
                        <p>Hi all</p>
                        <p>I just received one or two emails from a
                          colleague trying to install Xerte on a Windows
                          server and getting a message during setup that
                          'Your PHP does not seem to have MySQL support'
                          however phpinfo does show that MySQLi is
                          enabled.</p>
                        <p> </p>
                        <p>Do I recall previous discussion that the
                          current Xerte codebase isn't likely to work
                          with later versions of PHP because of MySQL
                          integration changes? This server is PHP 5.5.4.
                          If so has anyone been working on that for 2.1?</p>
                        <p> </p>
                        <p>Cheers</p>
                        <p>Ron</p>
                      </div>
                      <p class="MsoNormal"> </p>
                      <p>This message and any attachment are intended
                        solely for the addressee and may contain
                        confidential information. If you have received
                        this message in error, please send it back to
                        me, and immediately delete it.   Please do not
                        use, copy or disclose the information contained
                        in this message or in any attachment.  Any views
                        or opinions expressed by the author of this
                        email do not necessarily reflect the views of
                        the University of Nottingham.</p>
                      <p>This message has been checked for viruses but
                        the contents of an attachment may still contain
                        software viruses which could damage your
                        computer system, you are advised to perform your
                        own checks. Email communications with the
                        University of Nottingham may be monitored as
                        permitted by UK legislation.</p>
                      <p class="MsoNormal" style="margin-bottom:12.0pt"><br>
                        <br>
                        <br>
                        <br>
                      </p>
                    </div>
                  </div>
                </div>
              </div>
              <div>
                <div>
                  <br>
                  <p>This message and any attachment are intended solely
                    for the addressee and may contain confidential
                    information. If you have received this message in
                    error, please send it back to me, and immediately
                    delete it.   Please do not use, copy or disclose the
                    information contained in this message or in any
                    attachment.  Any views or opinions expressed by the
                    author of this email do not necessarily reflect the
                    views of the University of Nottingham.</p>
                  <p>This message has been checked for viruses but the
                    contents of an attachment may still contain software
                    viruses which could damage your computer system, you
                    are advised to perform your own checks. Email
                    communications with the University of Nottingham may
                    be monitored as permitted by UK legislation.</p>
                  <br>
                </div>
              </div>
            </div>
            <br>
            _______________________________________________<br>
            Xerte-dev mailing list<br>
            <a href="mailto:Xerte-dev@lists.nottingham.ac.uk" target="_blank">Xerte-dev@lists.nottingham.ac.uk</a><br>
            <a href="http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev" target="_blank">http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
Xerte-dev mailing list
<a href="mailto:Xerte-dev@lists.nottingham.ac.uk" target="_blank">Xerte-dev@lists.nottingham.ac.uk</a>
<a href="http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev" target="_blank">http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev</a>
</pre>
    </blockquote>
    <br>
    </div></div><span class="HOEnZb"><font color="#888888"><pre cols="72">-- 
--

Tom Reijnders
TOR Informatica
Chopinlaan 27
5242HM Rosmalen
Tel: 073 5226191
Fax: 073 5226196

</pre>
  </font></span></div>

</blockquote></div><br></div>