<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>Hi all and I guess mainly Pat...<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Julian previously reported this visual error e.g. the confirmation dialogue when trying to delete an empty folder works but shows some rogue html instead of the folder name as well as a typo in the message e.g. something like:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><img style="vertical-align:middle" src="website_code/images/Icon_Folder_Empty.gif"<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Are you sure you <u><span style='color:red'>with</span></u> to delete?<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>As far as I can tell this has existed for ages and isn't new to 1.8 but still exists in 1.8.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Fixing the typo e.g. replacing 'with' with 'wish' in both \website_code\scripts\template_management.js and \languages\en-GB\website_code\scripts\template_management.js is obviously easy and I have done that on the files I've been testing. However the main issue seems to be with the split used to display the name of the item selected...<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>in \website_code\scripts\template_management.js the relevant section is the following:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> if(drag_manager.selected_items.length!=1){<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> var response = confirm("Are you sure you wish to delete these item?");<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> }else{<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> data_string = drag_manager.selected_items[0].innerHTML;<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> name_string = data_string.split(">");<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> var response = confirm(name_string[1] + "\n\nAre you sure you wish to delete?");<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>when a folder is selected for deletion data_string equals something like:<o:p></o:p></p><p class=MsoNormal><P><IMG style="VERTICAL-ALIGN:middle" src="website_code/images/Icon_Folder_Empty.gif">new folder2</P><o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>when a file is selected for deletion data_string equals something like:<o:p></o:p></p><p class=MsoNormal><IMG style="VERTICAL-ALIGN:middle" src="http://localhost/newxottrunktest//website_code/images/Icon_Page.gif">test lo<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>so when a file is selected for deletion var response = confirm(name_string[1] correctly results in just the file name but when a folder is selected var response = confirm(name_string[2] would be a closer match displaying the folder name but ending with </P<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>The easiest way I could think of to fix this is to first strip out the <P> and </P> so that the spit is correct for both file and folder deletion. So the section of code now looks like:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>if(drag_manager.selected_items.length!=1){<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> var response = confirm("Are you sure you wish to delete these item?");<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> }else{<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> data_string = drag_manager.selected_items[0].innerHTML;<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> <span style='color:red'>data_string = data_string.replace("<P>","");<o:p></o:p></span></p><p class=MsoNormal><span style='color:red'> data_string = data_string.replace("</P>","");<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> name_string = data_string.split(">");<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> var response = confirm(name_string[1] + "\n\nAre you sure you wish to delete?");<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>This seems to work fine and correctly displays the file name or folder name in the deletion confirmation dialogue.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:red'>So question mainly for Pat - is this ok and if so shall I commit the changes or is there a better way to fix this? <o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Cheers<o:p></o:p></p><p class=MsoNormal>Ron<o:p></o:p></p></div></body></html>