[Xerte-dev] Re: Various pull requests on github (sqlite support, security fixes, export zip fixes).

[David Goodwin]

Hi - Yes, database_library.php is the only place that has mysql_ calls.

There should also be a database_library_sqlite.php.

It's not particularly elegant, but the code should use one or the other 
to show it switching between the two.

I wasn't sure if it could be rewritten to use PDO or not (in that, I 
wasn't sure if PDO would be an acceptable solution).

David.

Tom Reijnders wrote:
>
> David,
>
> After the merge my database_library.php still uses mysql_ calls. Is
> that correct, or did something go wrong during the merge?
> It's easy enough to update now, but I was just wondering.
>
> Tom
>
> David Goodwin schreef op 12-5-2014 17:54:
>>
>> Hi,
>>
>> See :
>>
>> https://github.com/thexerteproject/xerteonlinetoolkits/pull/65
>>
>> * changes XOT to break it's dependency on mysql_ (outside of 'setup')
>> * removes the requirement to have mysql - it is defaulting to sqlite
>> - this ought to make it easier for people to test.
>> * removes any need to have a 'setup/' installer (to a large part).
>> Chucking the files into a web server and browsing to the install
>> should trigger it to create an empty database in the system temp dir.
>>
>>
>> See :
>>
>> https://github.com/thexerteproject/xerteonlinetoolkits/pull/66
>>
>> * When I browse away from the front page, or try and reload it,
>> Firefox get's stuck in a refresh loop.
>>
>>
>> and :
>>
>> See :
>>
>> https://github.com/thexerteproject/xerteonlinetoolkits/pull/57
>>
>> * Improve the storing of extra_flags against a template.
>> * Add new ZIP export module (use php's ZIP extension if possible,
>> otherwise fall back to the PHP userspace library).
>> * this should resolve memory limit issues with exporting zip files.
>>
>>
>> thanks
>> David.
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20140514/260b5704/attachment.html>