[Xerte-dev] Re: Too many places with duplicate code, and I lost track....

[Tom Reijnders]

I'll yet to fix It for now. Will clean It up later...

Julian Tenney <Julian.Tenney at nottingham.ac.uk> schreef:

>It should be, yes, and agree, we should tidy it up at some point,
>
>-----Original Message-----
>From: xerte-dev-bounces at lists.nottingham.ac.uk
>[mailto:xerte-dev-bounces at lists.nottingham.ac.uk] On Behalf Of Pat @
>Pgogy
>Sent: 18 February 2013 09:20
>To: For Xerte technical developers
>Subject: [Xerte-dev] Re: Too many places with duplicate code, and I
>lost track....
>
>Hello,
>
>I think, but am not sure, that only one set of the files is exported
>now. The code in the modules folder mirrors the desktop XOT export.
>This part of the code is a bit confused.
>
>Pop up should be in all three though
>
>Pgogy Webstuff - http://www.pgogywebstuff.com Makers of web things of a
>fair to middling quality
>
>On 18 Feb 2013, at 08:00, Tom Reijnders <reijnders at tor.nl> wrote:
>
>> I've got a problem with a xot installation and a scorm export.
>> 
>> This particular RLO is using the embedDiv model, and it works fine if
>you publish it from XOT, but exported to SCORM (can't test normal
>export yet, need user credentials first), it doesn't work.
>> 
>> As far as I can tell now, it's because the embedDiv tries to call
>resizePopup, but that doesn't exit in scormRLO.htm. As far as I can
>tell it doen's exist in modules/xerte/player/RLOobject.htm (used for a
>normal export) either, and I think it should.
>> 
>> A lot of code that is in the rlo object is duplicated.
>> 
>> There is a rloObject.js in the root of xerte that is similar but
>different than the rloObject.js used for export. There is popupCode in
>play.php, and in scromRLO.htm, rloObject.htm, scorm2004.htm, but the
>latter 3 miss some functions that are in player.php.
>> 
>> At some point in time we should clean this up. For now, Am I correct
>that resizePopup should be in scromRLO.htm, rloObject.htm,
>scorm2004.htm?
>> 
>> Tnx,
>> 
>> Tom
>> 
>> --
>> --
>> 
>> Tom Reijnders
>> TOR Informatica
>> Chopinlaan 27
>> 5242HM Rosmalen
>> Tel: 073 5226191
>> Fax: 073 5226196
>> 
>> 
>> _______________________________________________
>> Xerte-dev mailing list
>> Xerte-dev at lists.nottingham.ac.uk
>> http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
>> This message and any attachment are intended solely for the addressee
>and may contain confidential information. If you have received this
>message in error, please send it back to me, and immediately delete it.
>Please do not use, copy or disclose the information contained in this
>message or in any attachment.  Any views or opinions expressed by the
>author of this email do not necessarily reflect the views of the
>University of Nottingham.
>> 
>> This message has been checked for viruses but the contents of an 
>> attachment may still contain software viruses which could damage your
>computer system:
>> you are advised to perform your own checks. Email communications with
>
>> the University of Nottingham may be monitored as permitted by UK
>legislation.
>
>_______________________________________________
>Xerte-dev mailing list
>Xerte-dev at lists.nottingham.ac.uk
>http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
>
>_______________________________________________
>Xerte-dev mailing list
>Xerte-dev at lists.nottingham.ac.uk
>http://lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
>This message and any attachment are intended solely for the addressee
>and may contain confidential information. If you have received this
>message in error, please send it back to me, and immediately delete it.
>Please do not use, copy or disclose the information contained in this
>message or in any attachment.  Any views or opinions expressed by the
>author of this email do not necessarily reflect the views of the
>University of Nottingham.
>
>This message has been checked for viruses but the contents of an
>attachment
>may still contain software viruses which could damage your computer
>system:
>you are advised to perform your own checks. Email communications with
>the
>University of Nottingham may be monitored as permitted by UK
>legislation.

-- 
Verzonden van mijn Android telefoon met K-9 Mail.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.nottingham.ac.uk/pipermail/xerte-dev/attachments/20130218/2d956a50/attachment.html>